Skip to content

Conversation

pandablue0809
Copy link
Member

@pandablue0809 pandablue0809 requested a review from ihomp August 13, 2025 13:18
Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this sorting on a separate page - read the comments in the ticket

@pandablue0809 pandablue0809 requested a review from ihomp August 25, 2025 14:13
@pandablue0809
Copy link
Member Author

@ihomp
I fixed
plz review again

@ihomp
Copy link
Member

ihomp commented Aug 26, 2025

  1. do we have a timestamp or ledger number for orders? it would be nice to show timestamps instead of the sequence numbers. if not, its ok to have teh sequences.
  2. does it looks worse if the icon we put before the number in the formatamountIcon?
  3. we have text like

The last 5 DEX orders [View all (2 total)]

It is nice when there are more than 5 orders, but if orders <=5, may be we should just show

3 DEX orders [View details]

  1. right now there is no such page
    http://localhost:3000/en/account/r3rhWeE31Jt5sWmi4QiGLMZnY3ENgqw96W/dex

if we want to merge this PR, we should hide the link for now (while it is not ready), or we should create that page.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the comments

@pandablue0809 pandablue0809 requested a review from ihomp August 26, 2025 13:27
@pandablue0809
Copy link
Member Author

@ihomp
I hide the link for now
plz check

@ihomp ihomp merged commit b397104 into Bithomp:main Aug 26, 2025
@pandablue0809 pandablue0809 deleted the feat/set-order-on-dexOrderData branch August 26, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants